Re: pglog-rotator

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Andrew Sullivan <andrew(at)libertyrms(dot)info>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: pglog-rotator
Date: 2003-04-04 02:57:22
Message-ID: 20030404025722.GC7479@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Thu, Apr 03, 2003 at 09:10:39PM -0500, Andrew Sullivan wrote:

Nice little program! Thank you.

> ($dev,$ino,$mode,$nlink,$uid,$gid,$rdev,$size, $atime,$mtime,$ctime,$blksize,$blocks) = stat($err_log_file);

FWIW, if you are only going to use the filesize, this can be written as
$size = (stat($err_log_file))[7];

> open(LOG, ">>$err_log_file");

And this should probably be
open(LOG, ">>$err_log_file") or die "$err_log_file: $!";

or some other way of checking that the output file was really opened.

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Uno combate cuando es necesario... ¡no cuando está de humor!
El humor es para el ganado, o para hacer el amor, o para tocar el
baliset. No para combatir." (Gurney Halleck)

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-04-04 20:13:49 Re: Win32 path patch
Previous Message Andrew Sullivan 2003-04-04 02:10:39 pglog-rotator