Re: PQescapeBytea is not multibyte aware

From: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: mail(at)joeconway(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PQescapeBytea is not multibyte aware
Date: 2002-04-08 03:52:02
Message-ID: 20020408125202S.t-ishii@sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> Joe Conway <mail(at)joeconway(dot)com> writes:
> > No objection here, but can we wrap the change in #ifdef MULTIBYTE so
> > there's no effect for people who don't use MULTIBYTE?
>
> That opens up the standard set of issues about "what if your server is
> MULTIBYTE but your libpq is not?" It seems risky to me.

I have committed changes to the current source (without MULTIBYTE
ifdes). Will change t.2-stable tree soon.

I also added some careful handlings for memory allocation errors and
changed some questionable codes useing direct ASCII values 92 instead
of '\\' for example.
--
Tatsuo Ishii

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Swan 2002-04-08 04:09:07 Re: timeout implementation issues
Previous Message Tom Lane 2002-04-08 03:33:30 Re: RFC: Restructuring pg_aggregate

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-04-08 04:40:56 Re: unknownin/out patch (was [HACKERS] PQescapeBytea is not multibyte aware)
Previous Message Joe Conway 2002-04-08 02:43:20 Re: unknownin/out patch (was [HACKERS] PQescapeBytea is