Re: Unportable coding in reorderbuffer.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unportable coding in reorderbuffer.h
Date: 2014-03-07 18:27:28
Message-ID: 19789.1394216848@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> A patch fixing this is attached. I've added some more local variables to
> deal with the longer lines...

Since I've got a compiler in captivity that complains about this,
I'll take care of checking and committing this patch.

I still think it might be a good idea to spin up a buildfarm member
running "gcc -ansi -pedantic", even if we don't see that as a particularly
useful case in practice. Thoughts?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-03-07 18:38:32 Re: on_exit_reset fails to clear DSM-related exit actions
Previous Message Pavel Stehule 2014-03-07 18:24:08 proposal (9.5) : psql unicode border line styles