Re: WIP: to_char, support for EEEE format

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Brendan Jurd <direvus(at)gmail(dot)com>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: to_char, support for EEEE format
Date: 2009-08-10 17:51:28
Message-ID: 19564.1249926688@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tom Lane escribi:
>> Doesn't seem quite right. Should we throw error if the number of 9's
>> before the decimal point isn't 1?

> No, see
> http://archives.postgresql.org/message-id/4A68FAE4.50206@timbira.com

Ah, nothing like being bug-compatible with a bad implementation.
But I agree, if Oracle ignores the number of 9's there then we
should too.

BTW, this patch adds more NUM_cache_remove() calls. I'm planning
to commit it that way, unless you're just about to commit your PG_TRY
change? I agree with doing that, but figured it should be a separate
commit.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-08-10 17:55:07 Re: WIP: to_char, support for EEEE format
Previous Message Tom Lane 2009-08-10 17:45:45 Re: machine-readable explain output v4