Re: Should commit_delay be PGC_SIGHUP?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Should commit_delay be PGC_SIGHUP?
Date: 2013-03-22 02:14:53
Message-ID: 19501.1363918493@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> Only one setting will be best for the whole cluster, so neither the
> user nor the DBA gains if a user sets this to a different value than
> the one that has been determined to be optimal.

> Since we wait while holding the lock it is actually harmful to
> everyone if anybody sets a stupid value and might even be considered a
> denial of service attack.

> So there is a very good reason to make this SIGHUP, not just a whim.

Hmm. If a malicious user could hurt performance for other sessions with
a bad setting of commit_delay, then USERSET is clearly a bad idea.
But it still seems like it could be SUSET rather than SIGHUP.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2013-03-22 02:39:20 Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]
Previous Message Daniel Farina 2013-03-22 02:04:16 Re: postgres_fdw vs data formatting GUCs (was Re: [v9.3] writable foreign tables)