Re: poll: CHECK TRIGGER?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: poll: CHECK TRIGGER?
Date: 2012-03-07 21:15:20
Message-ID: 19397.1331154920@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Well, I guess I'm still of the opinion that the real question is
> whether the particular lint checks that Pavel's implemented are good
> and useful things. Has anyone spent any time looking at *that*? I'm
> not going to stand here and hold my breath over the interface, but it
> seems to me that if we don't know that we've got a worthwhile set of
> underlying functionality, sweating the interface too much is putting
> the cart before the horse.

No, that's backwards. I have every expectation that the specific set
of checks will be extended and improved in future. But changing the
framework, if we don't bother to get that right to start with, will be
much less pleasant.

Not that having useful checks is not an important part of the patch, of
course. But it's not what everyone has been focusing on, and I do not
believe that we were mistaken to be more worried about the framework.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2012-03-07 21:28:42 Re: poll: CHECK TRIGGER?
Previous Message Dan Ports 2012-03-07 21:15:18 Re: a slightly stale comment