Re: Materialized views WIP patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Kevin Grittner <kgrittn(at)ymail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Marko Tiikkaja <pgmail(at)joh(dot)to>, Greg Stark <stark(at)mit(dot)edu>
Subject: Re: Materialized views WIP patch
Date: 2013-02-22 08:10:12
Message-ID: 18535.1361520612@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-02-21 14:11:10 -0800, Kevin Grittner wrote:
>> DISABLE MATERIALIZED VIEW mv; -- ALTER clause for constraints
>> DISCARD MATERIALIZED VIEW DATA mv; -- session state
>> RELEASE MATERIALIZED VIEW DATA mv; -- savepoint
>> RESET MATERIALIZED VIEW DATA mv; -- run-time parameter
>>
>> I think any of these could work. I'm personally most inclined
>> toward DISABLE MATERIALIZED VIEW. It seems to convey the semantics
>> better, especially if you leave out DATA as an additonal word.

> I vote for RESET or DISCARD. DISABLE sounds more like you disable
> automatic refreshes or somesuch.

Yeah, I don't much like DISABLE either. I'm also concerned about
overloading RESET this way --- that statement has complicated-enough
syntax already, not to mention way too many shades of meaning. So that
leaves me voting for DISCARD M.V. DATA, which seems pretty precise.
It's a bit verbose, but since when has SQL been succinct?

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-02-22 08:37:44 Re: pgsql: Move relpath() to libpgcommon
Previous Message Alvaro Herrera 2013-02-22 01:49:54 pgsql: Move relpath() to libpgcommon

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-02-22 08:13:09 Re: use_remote_explain missing in docs of postgres_fdw
Previous Message David E. Wheeler 2013-02-22 04:48:44 OSSP UUID present but cannot be compiled