| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, stuart(at)stuartbishop(dot)net, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #6624: Tab completion of identifier containing single backslash triggers warnings |
| Date: | 2012-05-11 01:50:06 |
| Message-ID: | 18430.1336701006@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, May 2, 2012 at 6:29 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The only way we could suppress such warnings would be if we made
>> tab-complete.c use E'' strings for literals containing name prefixes;
>> which is perhaps doable but it would mean having tab-complete.c roll
>> its own string escaping rather than use any facility now available
>> from libpq.
> PQescapeLiteral will do the job, no? At least in 9.0+.
Hmm ... it would, but then psql would fail entirely when talking to
pre-8.1 servers, so we'd need to check the server version to decide
which quoting method to use. Do you think this is important enough to
add yet more version-specific tests to that code?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2012-05-11 09:42:22 | Re: BUG #6629: Creating a gist index fails with "too many LWLocks taken" |
| Previous Message | Tom Lane | 2012-05-10 19:55:11 | Re: BUG #6636: Variadic function fails with array type domain |