| From: | richhguard-monotone(at)yahoo(dot)co(dot)uk |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | PATCH: CreateComments: use explicit indexing for ``values'' |
| Date: | 2011-06-12 11:26:16 |
| Message-ID: | 183252.96819.qm@web86702.mail.ird.yahoo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
I'm new to PostgreSQL and git, but having read through the wiki entries such as http://wiki.postgresql.org/wiki/Submitting_a_Patch, I think I have a patch worthy of submission.
It's a readability improvement in src/backend/commands/comment.c (CreateComments function), which changes the existing code from incrementing a variable for use as the array index, to use explicit ``values'' instead.
This has the following benefits
1) The structure of ``values'' is now clear at first glance.
2) ``i'' is then only used for 1 reason; the for loop
The patch is based on "master", and all existing tests pass.
Regards
Richard
| Attachment | Content-Type | Size |
|---|---|---|
| create-comment-explicit-indexing-v1.patch | text/x-patch | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sushant Sinha | 2011-06-12 11:33:40 | pg_trgm: unicode string not working |
| Previous Message | Peter Eisentraut | 2011-06-12 09:48:35 | Re: procpid? |