From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Mark Cave-Ayland <mark(dot)cave-ayland(at)ilande(dot)co(dot)uk>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Joe Conway <mail(at)joeconway(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net> |
Subject: | Re: Commitfest problems |
Date: | 2014-12-15 20:34:51 |
Message-ID: | 17837.1418675691@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-12-15 11:52:35 -0800, Josh Berkus wrote:
>> On 12/15/2014 11:27 AM, Robert Haas wrote:
>>> I feel like we used to be better at encouraging people to participate
>>> in the CF even if they were not experts, and to do the best they can
>>> based on what they did know. That was a helpful dynamic. Sure, the
>>> reviews weren't perfect, but more people helped, and reviewing some of
>>> the patch well and some of it in a more cursory manner is way better
>>> than reviewing none of it at all.
>> Well, it was strongly expressed to me by a number of senior contributors
>> on this list and at the developer meeting that inexpert reviews were not
>> really wanted, needed or helpful.
> I think that's pretty far away from what was said.
Doesn't match my recollection either.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-12-15 20:44:54 | Re: Commit fest 2014-12, let's begin! |
Previous Message | Andrew Dunstan | 2014-12-15 20:29:19 | Re: Commitfest problems |