| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: quiet inline configure check misses a step for clang |
| Date: | 2014-04-03 14:15:33 |
| Message-ID: | 17506.1396534533@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-04-03 09:43:20 -0400, Tom Lane wrote:
>> I object to the latter; you're proposing to greatly increase the warning
>> noise seen with any compiler that issues a warning for this without caring
>> about .h vs .c. For somebody who finds gcc -pedantic unusable, I would
>> think you'd have a bit more sympathy for people using other compilers.
> Yea, but which compilers are that? The only one in the buildfarm I could
> find a couple weeks back was acc, and there's a flag we could add to the
> relevant template that silences it. I also don't think that very old
> platforms won't usually be used for active development, so a louder
> build there doesn't really have the same impact as noisy builds for
> actively developed on platforms.
Didn't we already have this discussion last year? The main points
are all mentioned in
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-04-03 14:16:58 | Re: quiet inline configure check misses a step for clang |
| Previous Message | Heikki Linnakangas | 2014-04-03 14:14:23 | WAL format and API changes (9.5) |