Re: proposal: rounding up time value less than its unit.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: proposal: rounding up time value less than its unit.
Date: 2014-08-23 20:38:57
Message-ID: 17056.1408826337@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> Tom Lane-2 wrote
>> Indeed. I have not understood why you are insisting on "round up"
>> semantics. Wouldn't it make more sense for the behavior to be "round to
>> nearest"? That would get rid of any worries about treating zero
>> specially.

> Wasn't the goal that all non-zero values result in the feature being
> enabled? With round nearest there will still be some values that are
> non-zero but that round to zero and thus disable the feature.

Ah. Okay, but then what's wrong with the original proposal of "use ceil()
instead of floor()"? Basically I think the idea of treating fractions
less than one differently from fractions greater than one is bogus; nobody
will ever find that intuitive.

Or we could adopt Peter's idea that zero shouldn't be special (instead
using, say, -1 to turn things off). But I'm afraid that would break way
too many peoples' configuration choices.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2014-08-23 21:32:27 Re: Removing dependency to wsock32.lib when compiling code on WIndows
Previous Message David G Johnston 2014-08-23 20:01:22 Re: proposal: rounding up time value less than its unit.