| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, steve k <steven(dot)c(dot)kohler(at)nasa(dot)gov>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PQputCopyData dont signal error |
| Date: | 2014-04-07 13:50:17 |
| Message-ID: | 16833.1396878617@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> To move the conversation along:
> https://github.com/postgres/postgres/blob/master/src/bin/psql/copy.c#L664
> Seems possibly even more robust than most people will code, but it's
> had a lot of real world testing.
Note that the looping behavior there is actually rather new, and is
probably unnecessary for 99% of applications; it would depend on what
your ambitions are for dealing gracefully with connection loss (and
even then, I think we were forced into this by pre-existing decisions
elsewhere in psql about where and how we handle connection loss).
The important thing for this question is the error reporting that
occurs at lines 692-694.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-04-07 14:03:27 | Re: Pending 9.4 patches |
| Previous Message | Tom Lane | 2014-04-07 13:40:30 | Re: [bug fix] pg_ctl always uses the same event source |