Re: info about patch: using parametrised query in psql

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: info about patch: using parametrised query in psql
Date: 2009-12-28 08:04:23
Message-ID: 162867790912280004g346724e1r6b84408c7a06232c@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2009/12/28 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Fri, Dec 25, 2009 at 3:10 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Fri, Dec 25, 2009 at 2:30 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>>> Works for me.  One small problem discussed upthread is that there
>>>> currently doesn't appear to be a libpq function that does
>>>> ident-quoting.  I'm thinking that we will need to add one to make this
>>>> work - is that going to be a problem?
>>>
>>> The rules for ident-quoting are simple and haven't changed over the
>>> years, so we don't really *need* a libpq function for it.  OTOH you
>>> could argue it's inconsistent that we have one and not the other.
>>
>> Yeah.  Plus it seems like a useful thing to have, anyway.
>>
>>>> I'm thinking that since we're
>>>> just adding a function it won't force an uncomfortable major-version
>>>> bump on libpq.
>>>
>>> Yeah, we have taken the position in the past that adding new functions
>>> doesn't require a soname bump.
>>
>> Good.
>
> So it seems we have agreement on a new direction for this work.  We
> will not add the \pexec option Pavel proposed as part of this patch;
> instead, we will consider a patch that makes :'foo' and :"foo" do
> literal and identifier quoting of the corresponding value.  Based on
> this, I am marking the existing patch as Returned with Feedback, since
> what is needed here will amount to a totally base of code, and we can
> consider the revised patch if any for whichever CommitFest is open at
> the time that patch is submitted.

ok

Pavel

>
> Thanks,
>
> ...Robert
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-12-28 08:22:14 Re: [PATCH] bugfix for int2vectorin
Previous Message Robert Haas 2009-12-28 07:59:01 Re: info about patch: using parametrised query in psql