Re: options for RAISE statement

From: "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: options for RAISE statement
Date: 2008-05-13 22:22:24
Message-ID: 162867790805131522m7f81f809r13c53c52c67c774d@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

2008/5/14 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com> writes:
>> I am sending enhanced version of original patch.
>
> Applied with syntax revisions as per pghackers discussion.

thank you
>
> I made a couple of other changes too: I took out the restriction against
> throwing codes that are category codes, and instead just documented that
> that might be a bad idea. I don't see a reason to prohibit that if
> people really want to do it.

I didn't see a reason to allow it - but I don't see it important

Also, for the few condition names that are
> duplicated in plerrcodes.h, I just made it throw the first sqlstate it
> finds, rather than complaining. This will work, in the sense that you
> can trap the error using the same condition name, and I don't think it's
> really important to make the user think about this.

I am afraid so this can be surprise for some people - but again it's
not necessary solve it now.

Regards
Pavel Stehule

>
> regards, tom lane
>

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-05-13 23:11:01 Re: Making sure \timing is on
Previous Message Tom Lane 2008-05-13 22:14:57 Re: options for RAISE statement