Re: Something flaky in the "relfilenode mapping" infrastructure

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Something flaky in the "relfilenode mapping" infrastructure
Date: 2014-06-14 00:16:12
Message-ID: 15877.1402704972@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch <noah(at)leadboat(dot)com> writes:
> On Thu, Jun 12, 2014 at 10:50:44PM -0400, Tom Lane wrote:
>> Alternatively, we could do something like you suggest but adjust the
>> second join so that it suppresses only rows in which mapped_oid is null
>> *and* there's no longer a matching OID in pg_class. That would provide
>> additional confidence that the null result is a valid indicator of a
>> just-dropped table.

> Can't hurt; I adjusted it along those lines and committed.

Looks good.

> For the record,
> the failure on prairiedog has appeared a third time:
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2014-06-13%2005%3A19%3A35

Yeah, I saw that. I wonder if we recently changed something that improved
the odds of the timing being just so. Two failures in two days seems out
of line with the critter's previous history.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2014-06-14 00:22:06 Built-in binning functions
Previous Message Noah Misch 2014-06-14 00:10:07 Re: Something flaky in the "relfilenode mapping" infrastructure