Re: proposal: rounding up time value less than its unit.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Tomonari Katsumata <katsumata(dot)tomonari(at)po(dot)ntts(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: proposal: rounding up time value less than its unit.
Date: 2014-08-21 15:16:39
Message-ID: 15325.1408634199@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> The patch also rounds a zero up to one. A naked zero with no unit is not
> affected, but e.g if you have "log_rotation_age=0s", it will not disable
> the feature as you might expect, but set it to 1 minute. Should we do
> something about that?

That sounds like a dealbreaker to me. There are enough places where zero
has special meaning that we should not *ever* change zero to non-zero
silently.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Baker, Keith [OCDUS Non-J&J] 2014-08-21 15:25:44 Re: Proposal to add a QNX 6.5 port to PostgreSQL
Previous Message Bruce Momjian 2014-08-21 15:15:24 Hardening pg_upgrade