| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Christian Kruse <christian(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: show relation and tuple infos of a lock to acquire |
| Date: | 2014-03-13 14:17:17 |
| Message-ID: | 15302.1394720237@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Well, it's sounding like we can only display the whole tuple if (1)
> the message level is less than ERROR and (2) the snapshot is an MVCC
> snapshot. That's an annoying and hard-to-document set of limitations.
> But we should be able to display the TID always, so I think we should
> drop the part of the patch that tries to show tuple data and revisit
> that in a future release if need be.
+1. That avoids the thing that was really bothering me about this
patch, which is that it seemed likely to create a whole new set of
failure modes. Every case in which the data-printing effort could
fail is a case where the patch makes things *less* debuggable, not
more so.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-03-13 14:19:00 | Re: BUG #9555: pg_dump for tables with inheritance recreates the table with the wrong order of columns |
| Previous Message | Fabrízio de Royes Mello | 2014-03-13 14:04:00 | Re: Is this a bug? |