Re: ruleutils vs. empty targetlists

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ruleutils vs. empty targetlists
Date: 2013-12-15 00:20:27
Message-ID: 15051.1387066827@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
> On 13 December 2013 15:07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> How about as-is in the back branches, and throw the new errors only
>> in HEAD?

> Seems reasonable.

After further experimentation I've concluded that maybe we'd better
not back-patch this change. The reason for my change of heart is
that in 8.4, the patch made plpgsql stop complaining that "return ;"
was missing an expression. While we could possibly fix that, or
just decide not to patch 8.4, it occurs to me that there might be
applications out there that are expecting "SELECT ;" to fail, too.
So the risk of undesirable behavior changes seems a little larger
than I'd previously believed, and I'm feeling that fixing this
corner case in the back branches is not worth that risk.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-12-15 01:00:30 Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Previous Message David Rowley 2013-12-15 00:08:42 Re: [PATCH] Negative Transition Aggregate Functions (WIP)