| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: Sharing record typmods between backends |
| Date: | 2017-09-15 03:29:05 |
| Message-ID: | 14352.1505446145@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Fri, Sep 15, 2017 at 3:03 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> - added typedefs to typedefs.list
> Should I do this manually with future patches?
FWIW, I'm not on board with that. I think the version of typedefs.list
in the tree should reflect the last official pgindent run. There's also
a problem that it only works well if *every* committer faithfully updates
typedefs.list, which isn't going to happen.
For local pgindent'ing, I pull down
https://buildfarm.postgresql.org/cgi-bin/typedefs.pl
and then add any typedefs created by the patch I'm working on to that.
But I don't put the result into the commit. Maybe we need a bit better
documentation and/or tool support for using an unofficial typedef list.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-09-15 03:38:09 | Re: pgsql: Add support for coordinating record typmods among parallel worke |
| Previous Message | Tom Lane | 2017-09-15 03:18:11 | Re: pgsql: Add support for coordinating record typmods among parallel worke |