From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
Cc: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com> |
Subject: | Re: [HACKERS] Fix mdsync never-ending loop problem |
Date: | 2007-04-11 14:11:33 |
Message-ID: | 13940.1176300693@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes:
> My first thought is that the cycle_ctr just adds extra complexity. The
> canceled-flag really is the key in Takahiro-san's patch, so we don't
> need the cycle_ctr anymore.
We don't have to have it in the sense of the code not working without it,
but it probably pays for itself by eliminating useless fsyncs. The
overhead for it in my proposed implementation is darn near zero in the
non-error case. Also, Takahiro-san mentioned at one point that he was
concerned to avoid useless fsyncs because of some property of the LDC
patch --- I wasn't too clear on what, but maybe he can explain.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2007-04-11 14:30:12 | Re: Vista/IPv6 |
Previous Message | Andrew Dunstan | 2007-04-11 14:08:36 | Re: Vista/IPv6 |
From | Date | Subject | |
---|---|---|---|
Next Message | Merlin Moncure | 2007-04-11 17:24:52 | patch to suppress psql timing output in quiet mode |
Previous Message | NikhilS | 2007-04-11 08:26:22 | UPDATE using sub selects |