Re: [PATCH] Store Extension Options

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: fabriziomello(at)gmail(dot)com
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Store Extension Options
Date: 2014-01-11 04:47:07
Message-ID: 1389415627.12505.11.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 2014-01-11 at 00:48 -0200, Fabrízio de Royes Mello wrote:
> > Now, if bdr is installed but the validation doesn't happen unless
> bdr
> > is "loaded" in some sense, then that is an implementation deficiency
> > that I think we can insist be rectified before this feature is
> accepted.
> >

> Check if extension is already installed is not enough for the first
> version of this feature?

Elsewhere it was argued that tying this to extensions is not
appropriate. I agree.

It depends on how this feature is supposed to be used exactly. A
replication plugin might very well be loaded via
session_preload_libraries and not appear in SQL at all. In that case
you need some C-level hook. In another case, an extension might want to
inspect relation options from user-space triggers. So you'd need to
register some SQL-level function for option validation.

This could end up being two separate but overlapping features.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2014-01-11 06:01:02 Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE
Previous Message Peter Geoghegan 2014-01-11 03:59:01 Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE