pgcrypto missing header file inclusions

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: 'pgsql-hackers' <pgsql-hackers(at)postgresql(dot)org>
Subject: pgcrypto missing header file inclusions
Date: 2013-12-29 03:36:19
Message-ID: 1388288179.18242.8.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

While playing around with the pginclude tools, I noticed that pgcrypto
header files are failing to include some header files whose symbols they
use. This change would fix it:

diff --git a/contrib/pgcrypto/pgp.h b/contrib/pgcrypto/pgp.h
index 3022abf..f856e07 100644
--- a/contrib/pgcrypto/pgp.h
+++ b/contrib/pgcrypto/pgp.h
@@ -29,6 +29,9 @@
* contrib/pgcrypto/pgp.h
*/

+#include "mbuf.h"
+#include "px.h"
+
enum PGP_S2K_TYPE
{
PGP_S2K_SIMPLE = 0,

Does that look reasonable?

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2013-12-29 04:32:51 Re: Planning time in explain/explain analyze
Previous Message Tom Lane 2013-12-29 01:57:54 Re: [PATCH] work_mem calculation possible overflow