Re: [BUG FIX] Version number expressed in octal form by mistake

From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>, Joel Jacobson <joel(at)trustly(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUG FIX] Version number expressed in octal form by mistake
Date: 2013-12-27 22:17:47
Message-ID: 1388182667.84788.YahooMailNeo@web122305.mail.ne1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
> Joel Jacobson <joel(at)trustly(dot)com> wrote:
>
>> As reported by Andrey Karpov in his article
>> http://www.viva64.com/en/b/0227/
>> the version number is expressed in octal form 070100 should be
>> changed to 70100.
>>
>> Attached patch fixes the reported issue.
>
> This is a bug, but it's not clear what the correct patch should
> be.

Oh, I just noticed that this is for the *pg_restore* code, not the
pg_dump code, so there isn't necessarily a conflict with the docs.
The pg_dump code does match the docs on its version check. The
question becomes, for each supported version, what do we want to
set into AHX->minRemoteVersion before opening the connection to the
target database?  Do we really want a 9.4 executable to be
attempting to restore to a 7.1 database cluster?  What about
backpatching?

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2013-12-27 22:23:38 Re: BUG #8676: Bug Money JSON
Previous Message Peter Geoghegan 2013-12-27 22:11:44 Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE