| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Oskari Saarenmaa <os(at)ohmu(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] configure: allow adding a custom string to PG_VERSION |
| Date: | 2013-11-24 01:30:38 |
| Message-ID: | 1385256638.13910.5.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2013-11-20 at 22:41 +0900, Michael Paquier wrote:
> Here are a couple of comments about the patch:
> 1) I think that you should regenerate ./configure as well with this
> patch to include all the changes together (someone correct me if I am
> wrong here!)
Doesn't matter either way.
> 2) This new option should be added in the section "## Command line
> options" in configure.in
Yes.
> 3) PG_VERSION is not a variable name adapted IMO, as it might contain
> custom information. Something like PG_VERSION_TOTAL perhaps?
I don't think it's necessary to split this up further. We have
PG_VERSION and PG_MAJORVERSION. What's the use for one more level?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2013-11-24 01:58:13 | Re: pg_stat_statements: calls under-estimation propagation |
| Previous Message | Vik Fearing | 2013-11-24 01:03:18 | Re: CREATE FOREIGN TABLE ( ... LIKE ... ) |