Re: [GENERAL] pg_upgrade ?deficiency

From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Karsten Hilbert <Karsten(dot)Hilbert(at)gmx(dot)net>, "Hilbert, Sebastian" <Sebastian(dot)Hilbert(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [GENERAL] pg_upgrade ?deficiency
Date: 2013-11-22 20:14:03
Message-ID: 1385151243.98417.YahooMailNeo@web162903.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> wrote:

>> Not sure about backpatching.  default_transaction_read_only has been
>> around since 7.4.  Setting it to true would cause pg_dump to fail unless
>> you changed the database setting, and pg_dumpall would fail completely
>> as there is no way to turn off the database setting.

See the attached patch.  It seems to fix pg_dump and pg_dumpall.  I
don't think it will cause any problem for *dumping* earlier
versions,  Backpatching would mean that if you try to restore a
dump made by 8.4 or later software to a 7.3 or earlier database,
you would get an error; but I don't think that's supported, and I
would be amazed if that were the *only* error you got if you tried
that.

>> The problem is that I don't remember any report of this failing in
>> pg_dump, pg_dumpall, or pg_upgrade, so saying it is a major issue is
>> hard to accept.

Any time that you can appear to successfully dump a database, and
the restore attempt fails, I consider that to be a major issue.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Kevin Grittner 2013-11-22 20:18:16 Re: pg_xlog is getting bigger
Previous Message Tom Lane 2013-11-22 20:13:33 Re: pg_upgrade ?deficiency

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-11-22 20:15:46 Re: Why is UPDATE with column-list syntax not implemented
Previous Message Tom Lane 2013-11-22 20:13:33 Re: pg_upgrade ?deficiency