| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: psql tab completion for updatable foreign tables |
| Date: | 2013-10-17 02:29:19 |
| Message-ID: | 1381976959.19926.15.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2013-07-08 at 16:04 +0000, Dean Rasheed wrote:
> There was concern that pg_relation_is_updatable() would end up opening
> every relation in the database, hammering performance. I now realise
> that these tab-complete queries have a limit (1000 by default) so I
> don't think this is such an issue. I tested it by creating 10,000
> randomly named auto-updatable views on top of a table, and didn't see
> any performance problems.
Even if performance isn't a problem, do we really want tab completion
interfering with table locking? That might be a step too far.
Personally, I think this is too fancy anyway. I'd just complete all
views and foreign tables and be done with it. We don't inspect
permissions either, for example. This might be too confusing for users.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Sewell | 2013-10-17 02:49:30 | Re: [PATCH] Add an ldapoption to disable chasing LDAP referrals |
| Previous Message | Alvaro Herrera | 2013-10-17 02:23:49 | Re: FDW API / flow charts for the docs? |