| From: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Dan Ports <drkp(at)csail(dot)mit(dot)edu> |
| Subject: | Re: SSI freezing bug |
| Date: | 2013-10-04 14:31:03 |
| Message-ID: | 1380897063.47516.YahooMailNeo@web162905.mail.bf1.yahoo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
> I'm strongly leaning toward the idea that a slightly tweaked
> version of the proposed patch is appropriate for the back-branches,
> because the fix Heikki is now suggesting seems too invasive to
> back-patch. I think it would make sense to apply it to master,
> too, so that the new isolation tests can be immediately added. We
> can then work on the new approach for 9.4 and have the tests to
> help confirm we are not breaking anything. The tweak would be to
> preserve the signature of heap_freeze_tuple(), because after the
> more invasive fix in 9.4 the new parameters will not be needed.
> They are only passed as non-NULL from one of the three callers, so
> it seems best to leave those call sites alone rather than change
> them back-and-forth.
>
> I will post a new patch today or tomorrow.
Attached.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| freeze-ssi-v2.patch | text/x-diff | 92.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | MauMau | 2013-10-04 14:31:48 | Re: 9.4 HEAD: select() failed in postmaster |
| Previous Message | David Rowley | 2013-10-04 14:23:52 | pg_dump insert with column names speedup |