[9.4] Make full_page_writes only settable on server start?

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: [9.4] Make full_page_writes only settable on server start?
Date: 2013-09-03 02:10:57
Message-ID: 1378174257.19551.8.camel@jdavis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

There is a significant amount of code supporting the changing of
full_page_writes while the server is running, including an
XLOG_FPW_CHANGE wal record. But I don't see the use-case; surely almost
nobody changes this on a running server, because either your filesystem
guarantees atomic page writes for you or not.

I'd like to submit a patch to just make it into a PGC_POSTMASTER and
remove the code to support changing it.

Then, I intend to write another patch to make the full-page writes for
checksums honor the full_page_writes setting. That will be easier to
write once it's a PGC_POSTMASTER.

Any reason to keep the setting as a PGC_SIGHUP?

Regards,
Jeff Davis

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Boguk, Maksym 2013-09-03 02:28:45 UTF8 national character data type support WIP patch and list of open issues.
Previous Message Robert Haas 2013-09-03 01:23:54 Re: dynamic shared memory