| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Stark <stark(at)enterprisedb(dot)com> |
| Cc: | Robert Lor <Robert(dot)Lor(at)sun(dot)com>, Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: DTrace probes broken in HEAD on Solaris? |
| Date: | 2009-03-25 00:55:31 |
| Message-ID: | 13769.1237942531@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greg Stark <stark(at)enterprisedb(dot)com> writes:
> On Tue, Mar 24, 2009 at 9:31 PM, Robert Lor <Robert(dot)Lor(at)sun(dot)com> wrote:
>> I think the is-enabled test will address the issues you encountered. I see a
>> few alternative to fixing this:
> Another option is to impose a policy that all arguments to probes must
> be simple local variables -- no expressions.
IOW, if you need to trace on an expression, you have to calculate it
whether or not ENABLE_DTRACE is even defined? This doesn't seem to
me that it solves anything. The cases that are interesting are where a
probe needs a value that otherwise wouldn't be needed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2009-03-25 01:03:15 | Re: Function C and INOUT parameters |
| Previous Message | Tom Lane | 2009-03-25 00:51:53 | Re: improving concurrent transactin commit rate |