| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Mark Wong <markwkm(at)gmail(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Chetan Suttraway <chetan(dot)suttraway(at)enterprisedb(dot)com> |
| Subject: | Re: Re: [Review] Add SPI_gettypmod() to return a field's typemod from a TupleDesc |
| Date: | 2013-07-08 00:55:01 |
| Message-ID: | 1373244901.12837.29.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 2013-07-07 at 20:15 -0400, Noah Misch wrote:
> I mildly recommend we reject this patch as such, remove the TODO item,
> remove
> the XXX comments this patch removes, and plan not to add more trivial
> SPI
> wrappers. If consensus goes otherwise, I think we should at least
> introduce
> SPI_getcollation() at the same time. Code that needs to transfer one
> of them
> very often needs to transfer the other. Having API coverage for just
> one
> makes it easier for hackers to miss that.
The question is, what would one do with those values? It's hard to see
when you would need the typmod and the collation of a result set. There
might be cases, but enough to provide a special API for it?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2013-07-08 01:03:24 | Re: [PATCH] Add session_preload_libraries configuration parameter |
| Previous Message | Noah Misch | 2013-07-08 00:15:00 | Re: [Review] Add SPI_gettypmod() to return a field's typemod from a TupleDesc |