Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

From: Jameison Martin <jameisonb(at)yahoo(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>, Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Kevin Grittner <kgrittn(at)mail(dot)com>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]
Date: 2013-06-24 21:03:21
Message-ID: 1372107801.90455.YahooMailNeo@web160103.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

i believe the last submission of the patch had no negative performance impact on any of the tested use cases, but you'd have to go back and see the last exchange on that. 

i think it was the concern about potentially regressing the codeline in unforeseen ways without a clear benefit to all but one use case (wide tables) that stalled things.

>________________________________
> From: Josh Berkus <josh(at)agliodbs(dot)com>
>To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
>Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>; Amit Kapila <amit(dot)kapila(at)huawei(dot)com>; Andres Freund <andres(at)2ndquadrant(dot)com>; Craig Ringer <craig(at)2ndquadrant(dot)com>; Jameison Martin <jameisonb(at)yahoo(dot)com>; Noah Misch <noah(at)leadboat(dot)com>; Kevin Grittner <kgrittn(at)mail(dot)com>; robertmhaas(at)gmail(dot)com; pgsql-hackers(at)postgresql(dot)org
>Sent: Monday, June 24, 2013 10:32 PM
>Subject: Re: [HACKERS] patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]
>
>
>Simon,
>
>> I think its rather a shame that the proponents of this patch have
>> tried so hard to push this through without working variations on the
>> theme. Please guys, go away and get creative; rethink the approach so
>> that you can have your lunch without anybody else losing theirs. I
>> would add that I have seen the use case and want to support it, but
>> we're looking to add to the codebase not just steal small bites of
>> performance from existing use cases.
>
>Do we really have ironclad numbers which show that the patch affects
>performance negatively?  I didn't think the previous performance test
>was comprehensive; I was planning to develop one myself this week.
>
>--
>Josh Berkus
>PostgreSQL Experts Inc.
>http://pgexperts.com
>
>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2013-06-24 21:09:18 Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]
Previous Message Simon Riggs 2013-06-24 21:02:02 Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]