From: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: changeset generation v5-01 - Patches & git tree |
Date: | 2013-06-24 14:48:13 |
Message-ID: | 1372085293.60095.YahooMailNeo@web162902.mail.bf1.yahoo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2013-06-24 06:44:53 -0700, Kevin Grittner wrote:
>> Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>>> On 2013-06-23 08:27:32 -0700, Kevin Grittner wrote:
>>>>> + rm -f '$(DESTDIR)$(bindir)/pg_receivellog$(X)'
>>>> Oops. That part is not needed.
>>>
>>> Hm. Why not?
>>
>> Well, I could easily be wrong on just about anything to do with
>> make files, but on a second look that appeared to be dealing with
>> eliminating an installed pg_receivellog binary, which is not
>> created.
>
> I think it actually is?
Oh, yeah.... I see it now. I warned you I could be wrong. :-/
I just had a thought thought -- perhaps the dependency information
is being calculated incorrectly. Attached is the dependency file
from the successful build (with the adjusted Makefile), which still
fails the test_logical_decoding regression test, with the same diff.
--
Kevin Grittner
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
pg_receivellog.Po | text/x-gettext-translation | 2.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2013-06-24 14:49:53 | Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review] |
Previous Message | Fujii Masao | 2013-06-24 14:46:51 | Re: Support for REINDEX CONCURRENTLY |