Re: postgresql.auto.conf and reload

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgresql.auto.conf and reload
Date: 2014-07-09 04:44:32
Message-ID: 13719.1404881072@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Wed, Jul 9, 2014 at 6:40 AM, Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz>
> wrote:
>> Yes, but even well behaved users will see this type of error, because
>> initdb uncomments certain values (ones that are dead certs for being
>> changed via ALTER SYSTEM subsequently like shared_buffers), and then -
>> bang! your next reload gets that "your postgresql.conf contains errors"
>> message.

> That is the reason, why I have suggested up-thread that uncommented
> values should go to postgresql.auto.conf, that will avoid any such
> observations for a well-behaved user.

Uh, what? That sounds like you are proposing that postgresql.conf itself
is a dead letter. Which is not going to fly. We had that conversation
already.

The right way to fix this is just to avoid processing entries that get
overridden later in the configuration file scan. That won't cause anyone
to get upset about how their old habits no longer work.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2014-07-09 05:07:26 Re: psql: show only failed queries
Previous Message Amit Kapila 2014-07-09 03:18:39 Re: postgresql.auto.conf and reload