From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: event trigger API documentation? |
Date: | 2013-06-19 02:28:23 |
Message-ID: | 1371608903.13762.13.camel@vanquo.pezone.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 2013-05-06 at 17:17 +0200, Dimitri Fontaine wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > At this point, all that is appropriate is some documentation of the C
> > API. If the contrib example you have in mind is short enough, it might
> > as well become part of the example in the documentation.
>
> Please find attached a patch against the documentation, containing a
> full code example of what I had in mind. The contrib would only be
> useful to include if we want to ship something usable.
>
> As you might want to tinker with the code in the docs patch and easily
> check that it still runs, I include another patch with the new contrib
> module. I don't expect that to get commited, of course, but I had to do
> it to check the code so I'd better just share it, right?
Looks pretty good, but the description of the parsetree field was
obviously copied from somewhere else. I would fix it myself, but I
don't know what kind of assurances we want to offer about what's in that
field.
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2013-06-19 02:35:21 | Re: Patch for removng unused targets |
Previous Message | Greg Smith | 2013-06-19 01:17:49 | Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement) |