Re: Materialized View patch broke pg_dump

From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Bernd Helmle <mailings(at)oopsware(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Materialized View patch broke pg_dump
Date: 2013-03-14 01:30:20
Message-ID: 1363224620.48785.YahooMailNeo@web162904.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> On 03/11/2013 12:30 PM, Fujii Masao wrote:
>>> Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:

>>>> The problem is that pg_dump is sending an empty query in
>>>> versions less than 9.3, and choking on that. Suggested fix
>>>> attached - there's really no reason to be doing anything re mat
>>>> views in versions < 9.3.

>>> This is the same problem that I reported in another thread.
>>>
>>> http://www.postgresql.org/message-id/CAHGQGwH+4vtyq==L6HRuPxTggfqrnLf0mWj75BfisOske28gMA@mail.gmail.com
>>
>> Oh, I missed that. Yes, either of these would work.

> Will push a fix today unless I find that someone has beaten me to
> it as I work through the rest of the messages.

I agree that either would work.  I preferred Andrew's patch because
it kept knowledge of this issue more localized.

Pushed.  Thanks to you both, and apologies for the error.

Next time I do anything with pg_dump I will know better what
constitutes decent testing.

--
Kevin Grittner
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-03-14 02:45:04 Re: is it bug? - printing boolean domains in sql/xml function
Previous Message Luma 2013-03-14 01:05:27 TupleTable like data structure