| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_xlogdump |
| Date: | 2013-02-25 23:14:16 |
| Message-ID: | 1361834056.819.8.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 2013-02-24 at 09:34 -0500, Tom Lane wrote:
> > I independently wonder whether we should remove the PGXS stub from
> > xlogdump, given it relies on a full sourcetree available?
>
> I'd just as soon keep its Makefile looking like all the others.
>
If the code doesn't actually work, it should be deleted. There is no
value in keeping the Makefile looking like the others, because it
doesn't in fact look like the others.
I for one wonder why we even have PGXS support in contrib at all. It's
not documented or tested anywhere, so it might as well not exist.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2013-02-25 23:15:48 | pg_xlogdump compiler warning |
| Previous Message | Andrew Dunstan | 2013-02-25 22:37:03 | Re: json generation enhancements |