[PATCH] Fix NULL checking in check_TSCurrentConfig()

From: Xi Wang <xi(dot)wang(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Xi Wang <xi(dot)wang(at)gmail(dot)com>
Subject: [PATCH] Fix NULL checking in check_TSCurrentConfig()
Date: 2013-01-20 04:51:26
Message-ID: 1358657486-32676-1-git-send-email-xi.wang@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The correct NULL check should use `*newval'; `newval' must be non-null.
---
src/backend/utils/cache/ts_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/cache/ts_cache.c b/src/backend/utils/cache/ts_cache.c
index e688b1a..65a8ad7 100644
--- a/src/backend/utils/cache/ts_cache.c
+++ b/src/backend/utils/cache/ts_cache.c
@@ -642,7 +642,7 @@ check_TSCurrentConfig(char **newval, void **extra, GucSource source)
free(*newval);
*newval = strdup(buf);
pfree(buf);
- if (!newval)
+ if (!*newval)
return false;
}

--
1.7.10.4

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Xi Wang 2013-01-20 04:51:51 [PATCH] Fix off-by-one in PQprintTuples()
Previous Message Steve Singer 2013-01-20 04:42:02 Re: logical changeset generation v4