From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Event Triggers: adding information |
Date: | 2012-12-30 04:13:47 |
Message-ID: | 1356840827.20017.15.camel@vanquo.pezone.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, 2012-12-29 at 08:11 -0500, Robert Haas wrote:
> On Tue, Dec 25, 2012 at 1:42 PM, Dimitri Fontaine
> <dimitri(at)2ndquadrant(dot)fr> wrote:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> >>> Also, keep in mind we want the ObjectID in all CREATE, ALTER and DROP
> >>> statements, so my current patch is still some bricks shy of a load… (I
> >>> added ObjectID only in the commands I added rewrite support for, apart
> >>> from DROP).
> >>
> >> I shall rely on you to provide those bricks which are still missing.
> >
> > Please find attached a patch to change most functions called from
> > standard_ProcessUtility() to return an Oid (passes `make
> > maintainer-clean; configure; make install check`). Most of them only,
> > because it only make sense for functions touching an object that exists
> > in the catalogs and have a distinct Oid.
>
> OK, I committed this.
There is a new compiler warning coming from this, I believe:
copy.c: In function ‘DoCopy’:
copy.c:835:2: error: ‘relid’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
return relid;
^
copy.c:753:6: note: ‘relid’ was declared here
Oid relid;
^
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2012-12-30 04:21:31 | Re: enhanced error fields |
Previous Message | Peter Eisentraut | 2012-12-30 04:09:30 | Re: Documentation bug for LDAP authentication |