From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
Subject: | Re: embedded list v2 |
Date: | 2012-09-14 23:20:52 |
Message-ID: | 1347664431-sup-6085@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Excerpts from Tom Lane's message of vie sep 14 17:48:35 -0300 2012:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Here's an updated version of both patches, as well as a third patch that
> > converts the cc_node list link in catcache.c into an slist.
>
> There's a lot of stuff here that seems rather unfortunate and/or sloppy.
>
> Does it even compile? The 0002 patch refers to a typedef ilist_d_head
> that I don't see defined anywhere. (It would be good to shorten that
> name by a couple of characters anyway, for tab-stop alignment reasons.)
Hm, I might have submitted the wrong 0002 file. Sorry about that. (The
correct file would have the right typedef names and a couple of bugfixes
but it'd be pretty similar to what you read.)
> [many useful comments]
>
> Not a full review, just some things that struck me in a quick scan...
Great stuff nonetheless, many thanks. I will see about submitting an
improved version.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2012-09-15 00:33:25 | [RFC][PATCH] wal decoding, attempt #2 |
Previous Message | Tom Lane | 2012-09-14 22:30:08 | Re: Cause of recent buildfarm failures on hamerkop |