Re: pg_restore logging inconsistency

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Bosco Rama <postgres(at)boscorama(dot)com>
Subject: Re: pg_restore logging inconsistency
Date: 2012-06-19 21:56:36
Message-ID: 1340142686-sup-2814@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Excerpts from Josh Kupershmidt's message of mié may 30 14:55:12 -0400 2012:
> Hi all,
>
> Bosco Rama recently complained[1] about not seeing a message printed
> by pg_restore for each LO to be restored. The culprit seems to be the
> different level passed to ahlog() for this status message:
>
> pg_backup_archiver.c: ahlog(AH, 2, "restoring large object with OID %u\n", oid);
> pg_backup_tar.c: ahlog(AH, 1, "restoring large object OID %u\n", oid);
>
> depending on whether one is restoring a tar-format or custom-format
> dump. I think these messages should be logged at the same level, to
> avoid this inconsistency. The attached patch logs them both with
> level=1, and makes the message texts identical. Note, as of 9.0 there
> is already a line like this printed for each LO:
>
> pg_restore: executing BLOB 135004
>
> so I could see the argument for instead wanting to hide the "restoring
> large object" messages. However, the OP was interested in seeing
> something like a status indicator for the lo_write() calls which may
> take a long time, and the above message isn't really helpful for that
> purpose as it is printed earlier in the restore process. Plus it seems
> reasonable to make verbose mode, well, verbose.

I applied this patch all the way back to 8.3. Thanks.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-06-19 21:58:53 Re: [PATCH 10/16] Introduce the concept that wal has a 'origin' node
Previous Message Kevin Grittner 2012-06-19 21:53:56 Re: use of int4/int32 in C code