Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, PostgreSQL <Pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME
Date: 2011-10-12 14:50:17
Message-ID: 13389.1318431017@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> *shrug* ok. Another thought I had was to have the file raise an error
> and have that filtered out by the extension mechanism. But I'm not sure
> if it's worth the trouble.

Hmm ...

\echo You should use CREATE EXTENSION foo to load this file!

and teach CREATE EXTENSION to drop any line beginning with \echo?
The latter part seems easy enough, but I'm not quite sure about the
wording or placement of the \echo command. Putting it at the top
feels natural but the message might scroll offscreen due to errors...

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Aidan Van Dyk 2011-10-12 15:01:26 Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME
Previous Message Magnus Hagander 2011-10-12 14:33:26 Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME

Browse pgsql-hackers by date

  From Date Subject
Next Message Aidan Van Dyk 2011-10-12 14:58:00 Re: COUNT(*) and index-only scans
Previous Message Tom Lane 2011-10-12 14:37:11 Re: COUNT(*) and index-only scans