| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: building pg_dump doesn't work |
| Date: | 2009-03-04 15:11:25 |
| Message-ID: | 1335.1236179485@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Perhaps this could be made less ugly by only having the ScanKeywords
> array in the .c file, and #including that into other .c files in
> src/backend/parser, ecpg and pg_dump.
What I'd suggest is something similar to the design of the errcodes.h
header: create a header file containing just the list of PG_KEYWORD
macro calls, and have the different users #include it after defining
that macro appropriately. Having .c files include other .c files is
usually best avoided on least-surprise grounds.
> Not sure what to do about ScanKeywordLookup function.
Yeah, duplicating that function is a bit annoying.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2009-03-04 15:13:51 | Re: SQL/MED compatible connection manager |
| Previous Message | Heikki Linnakangas | 2009-03-04 15:06:55 | Re: building pg_dump doesn't work |