Re: walprotocol.h vs frontends

On mån, 2011-08-15 at 18:39 +0100, Peter Geoghegan wrote:
> > If you want to upgrade a system running 8.3 (that uses float based
> timestamps) in using
> > pg_upgrade you must compile 9.0 (or 8.4 or 9.1) with
> > --disable-integer-datetimes. If at some point in the future you
> then want
> > to upgrade to 9.2 with pg_upgrade you will again need to build 9.2
> with
> > --disable-integer-datetimes. If we remove the code for floating
> point
> > representations of datetime then you won't be able to do that.
>
> I'm pretty surprised that pg_upgrade pushes that onus onto its users -
> for many users, the need to build their own binaries is a greater
> barrier to upgrading than doing a logical restore. Maybe that's simply
> considered a matter for package managers to worry about, but that
> doesn't sit well with me.

Well, pg_upgrade only moves the heap files, it doesn't look into them or
change them.

Possibly, this sort of issue could be better handled in the future by
making this a cluster, database, or table flag instead of a compile-time
option. That way, at least newly created things could move to the new
recommended behavior. The way it is set up now, we will possibly never
get rid of the legacy behavior, unless we break pg_upgrade at some
point.