| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Sync Rep v19 |
| Date: | 2011-03-06 08:27:01 |
| Message-ID: | 1299400021.1696.72.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 2011-03-06 at 01:58 +0900, Fujii Masao wrote:
> On Sun, Mar 6, 2011 at 12:42 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> > New comments;
>
> Another one;
>
> + long timeout = SyncRepGetWaitTimeout();
> <snip>
> + else if (timeout > 0 &&
> + TimestampDifferenceExceeds(wait_start, now, timeout))
> + {
>
> The third argument of TimestampDifferenceExceeds is
> expressed in milliseconds. But you wrongly give that the
> microseconds.
Just for the record: that code section is now removed in v21
--
Simon Riggs http://www.2ndQuadrant.com/books/
PostgreSQL Development, 24x7 Support, Training and Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-03-06 11:36:09 | Improve check for TOAST checks in pre-8.4 pg_upgrade servers |
| Previous Message | Simon Riggs | 2011-03-06 08:26:18 | Re: Sync Rep v19 |