Re: ALTER EXTENSION UPGRADE, v3

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Aidan Van Dyk <aidan(at)highrise(dot)ca>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ALTER EXTENSION UPGRADE, v3
Date: 2011-02-17 13:59:23
Message-ID: 1297951163.31633.4.camel@fsopti579.F-Secure.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On fre, 2011-02-11 at 14:19 -0500, Tom Lane wrote:
> > But now, let's make it harder. I've found a grave bug in 1.1, which
> > causes the PG backend to segfault. Easy fix, good thing, so now I
> > release 1.2:
>
> Unless the bug is such that you have to change the installation script
> file, there is no reason to bump the version number at all. These
> version numbers apply to the install SQL script, not the
> underlying .so.

I think this shows that the installation script version number should be
independent of the overall package's version number. You just change
the installation script version number when it is required that the
script be run as part of an upgrade, otherwise you leave it. This is
very similar to the version numbers of shared libraries, which also
change independently of the overall package.

So perhaps installation script version numbers should just be integers
starting at 1, period.

Otherwise I fear people will try to make the numbers match their package
version number, which will either create stupid installation script
sequences or stupid package version numbers, like those peculiar fellows
who change the shared library version number in accordance with their
package version number.

This would of course also simplify many other aspects about which
version numbers to allow and how to compare them.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2011-02-17 14:02:57 Re: why two dashes in extension load files
Previous Message Gurjeet Singh 2011-02-17 12:30:05 Re: Fix for Index Advisor related hooks