| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>, Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: REVIEW: ALTER TABLE ... ADD FOREIGN KEY ... NOT ENFORCED |
| Date: | 2011-01-23 20:31:39 |
| Message-ID: | 1295814699.1803.20469.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 2011-01-23 at 14:45 -0500, Tom Lane wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> > On Sun, 2011-01-23 at 20:33 +0200, Marko Tiikkaja wrote:
> >> \d table now only shows that there's a FOREIGN KEY, which might lead the
> >> user to think that there should not be any values that don't exist in
> >> the referenced table.
>
> > Neither \d nor \di shows invalid indexes.
>
> Even if that were true, it's a poor analogy, since a disabled foreign
> key has visible *semantic* impact, whereas a disabled index doesn't.
Sure. My agreement to add something appears to have crossed with your
comments.
I'd appreciate you reviewing the parser aspects of the patch. $TITLE no
longer reflects the syntax.
--
Simon Riggs http://www.2ndQuadrant.com/books/
PostgreSQL Development, 24x7 Support, Training and Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitri Fontaine | 2011-01-23 20:49:50 | Re: Bug in pg_describe_object, patch v2 |
| Previous Message | Tom Lane | 2011-01-23 19:45:06 | Re: REVIEW: ALTER TABLE ... ADD FOREIGN KEY ... NOT ENFORCED |