From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: ALTER TYPE recursion to typed tables |
Date: | 2010-11-23 20:53:35 |
Message-ID: | 1290545615.24521.7.camel@vanquo.pezone.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On ons, 2010-11-17 at 21:05 +0100, Dimitri Fontaine wrote:
> Code wise, though, I wonder about the name of the "recursing"
> parameter of the renameatt_internal function is
> src/backend/commands/tablecmds.c,
> which seems to only get used to detect erroneous attempt at renaming
> the table column directly. Maybe it's only me not used enough to
> PostgreSQL code yet, but here it distract the code reader. Having
> another parameter called "recurse" is not helping, too, but I don't
> see this one needs to be changed.
This parameter has only minimal use in the renameatt case, but the same
terminology is used throughout the ALTER TABLE code, so I think it's
wise to keep it.
From | Date | Subject | |
---|---|---|---|
Next Message | Eliot Gable | 2010-11-23 20:55:55 | Re: Horizontal Write Scaling |
Previous Message | Peter Eisentraut | 2010-11-23 20:52:18 | pgsql: Remove useless whitespace at end of lines |