| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ALTER OBJECT any_name SET SCHEMA name |
| Date: | 2010-11-04 14:39:18 |
| Message-ID: | 1288881383-sup-5220@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from Dimitri Fontaine's message of jue nov 04 11:06:48 -0300 2010:
> Also attached, please find the complete version of ALTER EXTENSION ext
> SET SCHEMA name; with support for all contrib extensions. That's the
> example that allows to see the API (AlterFooNamespace_oid and _internal
> functions) in action: that should help devising the best refactoring.
Three comments,
1. wouldn't it make more sense to save the extension namespace in the
extension catalog?
2. I think the guts of AlterExtensionNamespace (the large switch block)
should be elsewhere, probably in alter.c
3. Not this patch, but I think using "extension" as a global variable
name is a bad idea.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-11-04 14:51:08 | Re: ALTER OBJECT any_name SET SCHEMA name |
| Previous Message | Tom Lane | 2010-11-04 14:39:16 | Re: Alter column to type serial |