| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | josh(at)agliodbs(dot)com, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: Re-thing PG_MODULE_MAGIC |
| Date: | 2006-06-16 03:39:46 |
| Message-ID: | 12822.1150429186@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Josh Berkus wrote:
>>> The <quote>magic block</> present in all PostgreSQL-supported libraries
>>> is checked to guarantee compatibility. For this reason, non-PostgreSQL
>>> libraries cannot be loaded in this way.
>>
>> you need "must be" before "present".
> Uh, the point is not that they need a magic block (though they do), but
> rather that the magic block is always checked.
It's a grammar complaint, not a factual complaint. Personally I'd
suggest wording it as "the magic block required in all ..."
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-06-16 03:57:22 | Re: Test request for Stats collector performance improvement |
| Previous Message | Rod Taylor | 2006-06-16 03:34:52 | Re: postgresql and process titles |